Fix search failure on user index due to nested owners query by sonika-shah · Pull Request #26794 · open-metadata/OpenMetadata

sonika-shah · 2026-03-26T10:24:20Z

Describe your changes:

The RBAC layer unconditionally adds nested owners queries to all search
requests. Indexes like user that don't have owners as a nested field
fail with "failed to find nested object under path [owners]".

Add ignore_unmapped=true to all nested queries so they gracefully return
no matches on indexes without the nested field instead of throwing 500.

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copilot

Pull request overview

Fixes search failures when RBAC injects owners nested queries against indexes where owners is not mapped as a nested field by adding ignore_unmapped=true to nested queries (Elasticsearch + OpenSearch), with accompanying test coverage.

Changes:

Add ignore_unmapped to nested query builders for Elasticsearch and OpenSearch.
Add ignore_unmapped to JSON-based nested query filters (e.g., owners filters) and assert it in unit tests.
Re-enable a previously skipped Playwright E2E test related to notification alerts.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/NotificationAlerts.spec.ts	Unskips an alerts permissions E2E flow.
openmetadata-service/src/main/java/org/openmetadata/service/search/opensearch/queries/OpenSearchQueryBuilder.java	Sets `ignoreUnmapped(true)` on nested queries built via the OpenSearch query builder.
openmetadata-service/src/main/java/org/openmetadata/service/search/opensearch/OpenSearchQueryBuilder.java	Sets `ignoreUnmapped(true)` on the static OpenSearch nested query helper.
openmetadata-service/src/main/java/org/openmetadata/service/search/elasticsearch/queries/ElasticQueryBuilder.java	Sets `ignoreUnmapped(true)` on nested queries built via the Elasticsearch query builder.
openmetadata-service/src/main/java/org/openmetadata/service/search/elasticsearch/ElasticQueryBuilder.java	Sets `ignoreUnmapped(true)` on the static Elasticsearch nested query helper.
openmetadata-service/src/main/java/org/openmetadata/service/search/SearchListFilter.java	Adds `ignore_unmapped:true` to the owners nested filter JSON.
openmetadata-service/src/main/java/org/openmetadata/service/search/QueryFilterBuilder.java	Adds `ignore_unmapped:true` to nested query JSON generated by filter builder helpers.
openmetadata-service/src/test/java/org/openmetadata/service/search/security/OpenSearchRBACConditionEvaluatorTest.java	Adds tests asserting nested query JSON includes `ignore_unmapped:true` (OpenSearch).
openmetadata-service/src/test/java/org/openmetadata/service/search/security/ElasticSearchRBACConditionEvaluatorTest.java	Adds tests asserting nested query JSON includes `ignore_unmapped:true` (Elasticsearch).
openmetadata-service/src/test/java/org/openmetadata/service/search/QueryFilterBuilderTest.java	Asserts `ignore_unmapped` is present in nested filters and adds additional nested-query structure checks.
openmetadata-service/src/test/java/org/openmetadata/service/jdbi3/SearchListFilterTest.java	Asserts `ignore_unmapped` is present in owners nested filters and updates expected serialized content.

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/NotificationAlerts.spec.ts

...src/main/java/org/openmetadata/service/search/opensearch/queries/OpenSearchQueryBuilder.java

github-actions · 2026-03-26T10:34:47Z

OpenMetadata Service New-Code Coverage

✅ PASS. Required changed-line coverage: 90.00% overall and per touched production file.

Overall executable changed lines: 7/7 covered (100.00%)
Missed executable changed lines: 0
Non-executable changed lines ignored by JaCoCo: 1
Changed production files: 6

File	Covered	Executable	Non-exec	Coverage	Uncovered lines
`openmetadata-service/src/main/java/org/openmetadata/service/search/QueryFilterBuilder.java`	3	3	0	100.00%	-
`openmetadata-service/src/main/java/org/openmetadata/service/search/elasticsearch/ElasticQueryBuilder.java`	1	1	0	100.00%	-
`openmetadata-service/src/main/java/org/openmetadata/service/search/elasticsearch/queries/ElasticQueryBuilder.java`	1	1	0	100.00%	-
`openmetadata-service/src/main/java/org/openmetadata/service/search/opensearch/OpenSearchQueryBuilder.java`	1	1	0	100.00%	-
`openmetadata-service/src/main/java/org/openmetadata/service/search/opensearch/queries/OpenSearchQueryBuilder.java`	1	1	0	100.00%	-
`openmetadata-service/src/main/java/org/openmetadata/service/search/SearchListFilter.java`	0	0	1	N/A	-

Only changed executable lines under openmetadata-service/src/main/java are counted. Test files, comments, imports, and non-executable lines are excluded.

github-actions · 2026-03-26T10:52:08Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	64.85% (58126/89627)	44.67% (30722/68764)	47.69% (9199/19289)

sonarqubecloud · 2026-03-26T10:54:07Z

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-26T12:22:47Z

🟡 Playwright Results — all passed (24 flaky)

✅ 3392 passed · ❌ 0 failed · 🟡 24 flaky · ⏭️ 216 skipped

Shard	Passed	Flaky	Skipped
🟡 Shard 1	450	5	2
🟡 Shard 2	598	6	32
🟡 Shard 3	604	5	27
🟡 Shard 4	598	5	47
✅ Shard 5	587	0	67
🟡 Shard 6	555	3	41

🟡 24 flaky test(s) (passed on retry)

Features/DataAssetRulesDisabled.spec.ts › Verify the Pipeline entity item action after rules disabled (shard 1, 1 retry)
Flow/Tour.spec.ts › Tour should work from help section (shard 1, 1 retry)
Flow/Tour.spec.ts › Tour should work from welcome screen (shard 1, 1 retry)
Flow/Tour.spec.ts › Tour should work from URL directly (shard 1, 1 retry)
Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › EditAll User: Complete export-import-validate flow (shard 2, 1 retry)
Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit icon on incidents (shard 2, 1 retry)
Features/DataQuality/TestCaseIncidentPermissions.spec.ts › User with only VIEW cannot PATCH incidents (shard 2, 1 retry)
Features/DataQuality/TestCaseResultPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit action on test case (shard 2, 1 retry)
Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
Flow/AddRoleAndAssignToUser.spec.ts › Verify assigned role to new user (shard 3, 1 retry)
Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
Flow/SchemaTable.spec.ts › schema table test (shard 3, 1 retry)
Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
Pages/DataContracts.spec.ts › Create Data Contract and validate for Table (shard 4, 1 retry)
Pages/DataContracts.spec.ts › Add and update Security and SLA tabs (shard 4, 1 retry)
Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Set (shard 4, 1 retry)
Pages/Domains.spec.ts › Rename domain with data products attached at domain and subdomain levels (shard 4, 1 retry)
Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
Pages/ServiceEntity.spec.ts › Tier Add, Update and Remove (shard 6, 1 retry)
Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

gitar-bot · 2026-03-27T14:47:41Z

Code Review ✅ Approved

Fixes search failure on the user index caused by nested owners query by ignoring unmapped fields. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-27T14:50:54Z

openmetadata-service/src/main/java/org/openmetadata/service/search/SearchListFilter.java

  private String getOwnerCondition() {
    String owners = getQueryParam("owners");
    if (!nullOrEmpty(owners)) {
      String ownersList =
          Arrays.stream(owners.split(",")).collect(Collectors.joining("\", \"", "\"", "\""));
      return String.format(
-          "{\"nested\":{\"path\":\"owners\",\"query\":{\"terms\":{\"owners.id\":[%s]}}}}",
+          "{\"nested\":{\"path\":\"owners\",\"query\":{\"terms\":{\"owners.id\":[%s]}},\"ignore_unmapped\":true}}",
          ownersList);
    }


PR description says to add ignore_unmapped=true to all nested queries, but in this class only the owners nested query was updated. There are other nested query JSON snippets built here (e.g., tags and testSuites) that still omit ignore_unmapped, so similar unmapped-field failures could still occur and the change is inconsistent with the stated intent. Consider adding ignore_unmapped to those nested clauses as well (and updating tests accordingly).

sonarqubecloud · 2026-03-27T15:49:13Z

Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Fix search failure on user index due to nested owners query

9f16c03

sonika-shah requested a review from a team as a code owner March 26, 2026 10:24

sonika-shah added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Mar 26, 2026

Copilot AI review requested due to automatic review settings March 26, 2026 10:24

github-actions bot added the backend label Mar 26, 2026

Copilot started reviewing on behalf of sonika-shah March 26, 2026 10:24 View session

sonika-shah removed the To release Will cherry-pick this PR into the release branch label Mar 26, 2026

Merge branch 'main' into nested-owners-query-ignore-unmapped

fcb99c1

Copilot AI reviewed Mar 26, 2026

View reviewed changes

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/NotificationAlerts.spec.ts Show resolved Hide resolved

...src/main/java/org/openmetadata/service/search/opensearch/queries/OpenSearchQueryBuilder.java Show resolved Hide resolved

ShaileshParmar11 approved these changes Mar 26, 2026

View reviewed changes

sonika-shah temporarily deployed to test March 26, 2026 10:36 — with GitHub Actions Inactive

Merge branch 'main' into nested-owners-query-ignore-unmapped

7bcddc5

sonika-shah enabled auto-merge (squash) March 27, 2026 04:04

sonika-shah temporarily deployed to test March 27, 2026 04:16 — with GitHub Actions Inactive

Merge branch 'main' into nested-owners-query-ignore-unmapped

b703a04

Copilot AI review requested due to automatic review settings March 27, 2026 14:46

Copilot started reviewing on behalf of sonika-shah March 27, 2026 14:47 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

sonika-shah requested a deployment to test March 27, 2026 14:56 — with GitHub Actions In progress

sonika-shah temporarily deployed to test March 27, 2026 14:56 — with GitHub Actions Inactive

sonika-shah requested a deployment to test March 27, 2026 14:56 — with GitHub Actions In progress

sonika-shah temporarily deployed to test March 27, 2026 14:56 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix search failure on user index due to nested owners query#26794

Fix search failure on user index due to nested owners query#26794
sonika-shah wants to merge 4 commits intomainfrom
nested-owners-query-ignore-unmapped

sonika-shah commented Mar 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

sonarqubecloud bot commented Mar 26, 2026

Uh oh!

github-actions bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

gitar-bot bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 27, 2026

Uh oh!

sonarqubecloud bot commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sonika-shah commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Type of change:

Checklist:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenMetadata Service New-Code Coverage

Uh oh!

github-actions bot commented Mar 26, 2026

Jest test Coverage

UI tests summary

Uh oh!

sonarqubecloud bot commented Mar 26, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

github-actions bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Playwright Results — all passed (24 flaky)

Uh oh!

gitar-bot bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 27, 2026

Quality Gate passed for 'open-metadata-ingestion'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sonika-shah commented Mar 26, 2026 •

edited

Loading

github-actions bot commented Mar 26, 2026 •

edited

Loading

github-actions bot commented Mar 26, 2026 •

edited

Loading

gitar-bot bot commented Mar 27, 2026 •

edited

Loading